Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook-config): added webpack sass to storybook config #7471

Merged
merged 3 commits into from
Dec 17, 2020
Merged

feat(storybook-config): added webpack sass to storybook config #7471

merged 3 commits into from
Dec 17, 2020

Conversation

aledavila
Copy link
Contributor

Phase 2:

This adds sass webpack config to the carbon storybook config package

Changelog

Changed

  • sass config now live in the config package

Removed

  • has been removed from react package

Testing / Reviewing

Make sure styles are appearing correctly and the stories work like they should be.

@aledavila aledavila requested a review from a team as a code owner December 16, 2020 18:11
@aledavila aledavila changed the title Storybook config sass feat(storybook-config): added webpack sass to storybook config Dec 16, 2020
@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 8c3d8fb

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fdbe3fcae16e600087c4cea

😎 Browse the preview: https://deploy-preview-7471--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: 8c3d8fb

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fdbe3fcacb2da0007a0fd47

😎 Browse the preview: https://deploy-preview-7471--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 22c1411 into carbon-design-system:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants